feat(#121): create RequestProcessor class#129
Merged
Conversation
- Add RequestProcessor for standalone service processing without a manager - Accepts WebService + optional Request + optional output stream - Handles full pipeline: content type, method check, params, auth, invocation - Internally uses WebServicesManager (single-service auto-select) - Add example in examples/04-advanced/04-request-processor/ - 6 new tests covering GET, POST, auth denial, method not allowed, content type - Step 4 of 5 in ADR-0005 (RequestProcessor refactor)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #129 +/- ##
=========================================
Coverage 93.64% 93.64%
Complexity 1316 1316
=========================================
Files 39 39
Lines 3180 3180
=========================================
Hits 2978 2978
Misses 202 202
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create a
RequestProcessorclass that processes a single web service against an HTTP request without requiring manual service registration or a fullWebServicesManagersetup. Step 4 of 5 in ADR-0005.Motivation
Processing a
WebServicecurrently requires instantiating a fullWebServicesManagerwith its registry. TheRequestProcessorprovides a simpler entry point when the caller already knows which service to invoke. Fixes #121.Changes
WebFiori\Http\RequestProcessorwithprocess(WebService $service, ?Request $request, $outputStream)methodWebServicesManagerinternally (single-service auto-select mode)examples/04-advanced/04-request-processor/UI Changes
N/A
How to Test / Verify
6 new tests, 11 assertions. Full suite: 530 tests pass.
Breaking Changes and Migration Steps
None. New class — purely additive.
Checklist
Related issues
Closes #121
Part of ADR-0005: https://github.com/WebFiori/docs/blob/main/adr/0005-request-processor-replaces-manager.md