[threads][test][js-api] Add tests for growing shared memory#248
Open
backes wants to merge 1 commit intoWebAssembly:mainfrom
Open
[threads][test][js-api] Add tests for growing shared memory#248backes wants to merge 1 commit intoWebAssembly:mainfrom
backes wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
Add a few first (!) js-api test to this repo. In particular: - Growing a non-shared memory always detaches the old buffer and allocates a fresh one (as before). - Growing a shared memory only refreshes the buffer if the delta in pages is > 0. - Growing a shared memory has no effect on unrelated shared memories. Note that V8 didn't implement this correctly until https://crrev.com/c/7660970, see https://crbug.com/492128992.
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Mar 16, 2026
Shared ArrayBuffers need replacement whenever their backing store grows, as they do not update their 'byteLength' automatically. This was previously done unconditionally for all shared memories on any growth (via 'UpdateSharedWasmMemoryObjects'). This CL changes it so only those 'JSArrayBuffer's are cleared (and thus refreshed on their next access) that are actually smaller than their backing store. Note that for non-shared memory, 'grow(0)' still detaches and replaces the buffer, as mandated by the current JS API spec. Shared memory follows the Threads proposal which specifically preserves identity when the length doesn't change. A respective spec test is added in WebAssembly/threads#248. R=jkummerow@chromium.org Bug: 492128992 Change-Id: I76a0f4ce23c98eb73c3a74c36fb0795f08e9ffa4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7660970 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#105812}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a few first (!) js-api test to this repo. In particular:
Note that V8 didn't implement this correctly until https://crrev.com/c/7660970, see https://crbug.com/492128992.