Skip to content

[interpreter] Reject subtypes with multiple supertypes #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanguineman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[interpreter] Reject subtypes with multiple supertypes #2232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions interpreter/valid/valid.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ let check_comptype (c : context) (ct : comptype) at =

let check_subtype (c : context) (sut : subtype) at =
let SubT (_fin, uts, ct) = sut in
require (List.length uts <= 1) at "multiple supertypes";
List.iter (fun ut -> check_typeuse c ut at) uts;
check_comptype c ct at

Expand Down
9 changes: 9 additions & 0 deletions test/core/gc/type-subtyping.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,6 +949,15 @@
"sub type"
)

;; Testing the number of allowed supertypes

(assert_invalid
(module
(type $parent1 (sub (struct)))
(type $parent2 (sub (struct)))
(type $child (sub $parent1 $parent2 (struct))))
"multiple supertypes"
)

;; Testing exported functions with non-flat types
(module
Expand Down