wasm-reduce: Fix up EH nested pops when adding blocks#8894
Merged
Conversation
stevenfontanella
approved these changes
Jul 10, 2026
stevenfontanella
left a comment
stevenfontanella
left a comment
Member
There was a problem hiding this comment.
Makes sense, but is it possible to write a test for this?
Member
Author
|
Not easily, unfortunately. This really requires some operation that modifies the wasm in this way - the new ConstraintAnalysis pass does that, but nothing else, and once it's fixed, it won't reproduce the issue either. We could in theory add some generic way to modify wasm in a wasm-reduce test... perhaps running a binaryen.js script that does a transform. Certainly worth thinking about in general. |
Member
|
SGTM in that case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.