-
Notifications
You must be signed in to change notification settings - Fork 869
ConstraintAnalysis: Add inequality parsing #8891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+937
−106
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
843feed
start
kripken c5cbb36
form
kripken 9432fe3
test
kripken b248ab5
test
kripken 047a97c
test
kripken 7127778
test
kripken 05af48d
test
kripken 882acb9
Merge remote-tracking branch 'origin/main' into ineq
kripken f99c0ed
undo
kripken cea10d2
test
kripken 4b8acf4
format
kripken c375024
format
kripken 6c021c5
add software bounds check test
kripken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| /* | ||
| * Copyright 2026 WebAssembly Community Group participants | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include "ir/abstract.h" | ||
| #include "wasm.h" | ||
|
|
||
| namespace wasm::Abstract { | ||
|
|
||
| std::ostream& operator<<(std::ostream& o, Op op) { | ||
|
|
||
| #define HANDLE(x) \ | ||
| case x: \ | ||
| return o << #x; | ||
|
|
||
| switch (op) { | ||
| HANDLE(Abs) | ||
| HANDLE(Neg) | ||
| HANDLE(Popcnt) | ||
| HANDLE(Add) | ||
| HANDLE(Sub) | ||
| HANDLE(Mul) | ||
| HANDLE(DivU) | ||
| HANDLE(DivS) | ||
| HANDLE(RemU) | ||
| HANDLE(RemS) | ||
| HANDLE(Shl) | ||
| HANDLE(ShrU) | ||
| HANDLE(ShrS) | ||
| HANDLE(RotL) | ||
| HANDLE(RotR) | ||
| HANDLE(And) | ||
| HANDLE(Or) | ||
| HANDLE(Xor) | ||
| HANDLE(CopySign) | ||
| HANDLE(EqZ) | ||
| HANDLE(Eq) | ||
| HANDLE(Ne) | ||
| HANDLE(LtS) | ||
| HANDLE(LtU) | ||
| HANDLE(LeS) | ||
| HANDLE(LeU) | ||
| HANDLE(GtS) | ||
| HANDLE(GtU) | ||
| HANDLE(GeS) | ||
| HANDLE(GeU) | ||
| default: | ||
| WASM_UNREACHABLE("bad abstract op"); | ||
| } | ||
| } | ||
|
|
||
| } // namespace wasm::Abstract |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of guess-and-check to see if the binary operation is one we support, can we instead have a function in
abstract.hto switch overbinary->opand return the correspondingAbstractop, if any? Then we can very efficiently skip operations that don't correspond to any abstract op.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can measure this and look for an optimization. Maybe as an NFC followup?
(The challenge is avoiding code duplication - the current way avoids writing the mapping of opcodes twice.)