Skip to content

Fuzzer: Fix subtyping of bottom types when fuzzing against JS#8683

Merged
kripken merged 2 commits intoWebAssembly:mainfrom
kripken:fuzz.against.subt
May 8, 2026
Merged

Fuzzer: Fix subtyping of bottom types when fuzzing against JS#8683
kripken merged 2 commits intoWebAssembly:mainfrom
kripken:fuzz.against.subt

Conversation

@kripken
Copy link
Copy Markdown
Member

@kripken kripken commented May 8, 2026

maybeRefine should refine between old and new, and we were missing
a check for being refined enough when traversing all subtypes of bottom.
As a result, we could un-refine, which can break if a call exists.

@kripken kripken requested a review from tlively May 8, 2026 15:21
@kripken kripken requested a review from a team as a code owner May 8, 2026 15:21
Copy link
Copy Markdown
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops!

@kripken kripken merged commit 6c32125 into WebAssembly:main May 8, 2026
16 checks passed
@kripken kripken deleted the fuzz.against.subt branch May 8, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants