Skip to content

GUFA: Handle suspend with value #8423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 2 commits into from
Mar 6, 2026
+109 −0
Merged

GUFA: Handle suspend with value #8423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aec2c3
fix
kripken Mar 5, 2026
a44e3c5
finish
kripken Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/ir/possible-contents.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1366,6 +1366,9 @@ struct InfoCollector
void visitSuspend(Suspend* curr) {
// TODO: optimize when possible
addRoot(curr);

// The given values are written to the tag, just the same as a throw.
handleThrow(curr);
}

template<typename T> void handleResume(T* curr) {
Expand Down
106 changes: 106 additions & 0 deletions test/lit/passes/gufa-cont.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,3 +281,109 @@
)
)
)

(module
;; CHECK: (type $func (func))
;; OPEN_WORLD: (type $func (func))
(type $func (func))

;; CHECK: (type $cont (cont $func))
(type $cont (cont $func))

;; CHECK: (type $func-i32 (func (param i32)))
;; OPEN_WORLD: (type $cont (cont $func))

;; OPEN_WORLD: (type $func-i32 (func (param i32)))
(type $func-i32 (func (param i32)))



;; CHECK: (type $3 (func (result i32)))

;; CHECK: (type $4 (func (result i32 (ref $cont))))

;; CHECK: (elem declare func $cont)

;; CHECK: (tag $tag (type $func))
;; OPEN_WORLD: (type $3 (func (result i32)))

;; OPEN_WORLD: (type $4 (func (result i32 (ref $cont))))

;; OPEN_WORLD: (elem declare func $cont)

;; OPEN_WORLD: (tag $tag (type $func))
(tag $tag (type $func))

;; CHECK: (tag $tag-i32 (type $func-i32) (param i32))
;; OPEN_WORLD: (tag $tag-i32 (type $func-i32) (param i32))
(tag $tag-i32 (type $func-i32))

;; CHECK: (export "resume" (func $resume))

;; CHECK: (func $cont (type $func)
;; CHECK-NEXT: (suspend $tag-i32
;; CHECK-NEXT: (i32.const 1337)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
;; OPEN_WORLD: (export "resume" (func $resume))

;; OPEN_WORLD: (func $cont (type $func)
;; OPEN_WORLD-NEXT: (suspend $tag-i32
;; OPEN_WORLD-NEXT: (i32.const 1337)
;; OPEN_WORLD-NEXT: )
;; OPEN_WORLD-NEXT: )
(func $cont
;; Helper for below.
(suspend $tag-i32
(i32.const 1337)
)
)

;; CHECK: (func $resume (type $3) (result i32)
;; CHECK-NEXT: (tuple.drop 2
;; CHECK-NEXT: (block $block (type $4) (result i32 (ref $cont))
;; CHECK-NEXT: (resume $cont (on $tag-i32 $block)
;; CHECK-NEXT: (cont.new $cont
;; CHECK-NEXT: (ref.func $cont)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
;; CHECK-NEXT: (return
;; CHECK-NEXT: (i32.const 42)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
;; CHECK-NEXT: )
;; CHECK-NEXT: (i32.const 1337)
;; CHECK-NEXT: )
;; OPEN_WORLD: (func $resume (type $3) (result i32)
;; OPEN_WORLD-NEXT: (tuple.drop 2
;; OPEN_WORLD-NEXT: (block $block (type $4) (result i32 (ref $cont))
;; OPEN_WORLD-NEXT: (resume $cont (on $tag-i32 $block)
;; OPEN_WORLD-NEXT: (cont.new $cont
;; OPEN_WORLD-NEXT: (ref.func $cont)
;; OPEN_WORLD-NEXT: )
;; OPEN_WORLD-NEXT: )
;; OPEN_WORLD-NEXT: (return
;; OPEN_WORLD-NEXT: (i32.const 42)
;; OPEN_WORLD-NEXT: )
;; OPEN_WORLD-NEXT: )
;; OPEN_WORLD-NEXT: )
;; OPEN_WORLD-NEXT: (i32.const 1337)
;; OPEN_WORLD-NEXT: )
(func $resume (export "resume") (result i32)
;; A continuation is created, it suspends, and we handle that. We can even
;; infer the suspended value, 1337.
(tuple.extract 2 0
(block $block (result i32 (ref $cont))
(resume $cont (on $tag-i32 $block)
(cont.new $cont
(ref.func $cont)
)
)
(return
(i32.const 42)
)
)
)
)
)

Loading