Conversation
Also, update the script to run against modern emscripten/clang.
tlively
approved these changes
Feb 26, 2026
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
LGTM, but can you remind me what the lld tests are for?
Member
Author
Great questions. This cleanups are part of reminding myself what they are for. IIRC there are tests for the wasm-emscripten-finalize tool which is designed to run on the binaries produces by lld. As part of this cleanup I was thinking of rename these from "lld" to "finalize" tests. I'd also love to completely delete these tests, but I think that would first need to completely delete wasm-emscripten-finalize (and replace it with just a bunch of normal passes, maybe?) |
Member
Author
|
@kripken can you take a look at this too before it lands? |
kripken
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, update the script to run against modern emscripten/clang.