Vacuum: Do not turn unreachable into nop#8387
Open
kripken wants to merge 3 commits intoWebAssembly:mainfrom
Open
Vacuum: Do not turn unreachable into nop#8387kripken wants to merge 3 commits intoWebAssembly:mainfrom
kripken wants to merge 3 commits intoWebAssembly:mainfrom
Conversation
tlively
approved these changes
Feb 25, 2026
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
LGTM whether we want to wait for some kind of propagation or not.
Member
Author
|
Actually we don't need any propagation 😄 Inlining does it. Added a test to verify. |
tlively
reviewed
Feb 26, 2026
| ;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited. | ||
|
|
||
| ;; RUN: foreach %s %t wasm-opt --inlining -S -o - | filecheck %s | ||
| ;; RUN: foreach %s %t wasm-opt --inlining -tnh -S -o - | filecheck %s |
Member
There was a problem hiding this comment.
should this have a different check prefix?
Member
Author
There was a problem hiding this comment.
Why, if the result is the same?
Member
There was a problem hiding this comment.
Oh I see, I was confused about why they would be the same. This is just doing inlining, not vacuuming.
tlively
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows propagation of unreachability to callers.
We do not propagate it yet though, so we may want to wait on landing this.