[NFC-for-now] Fix LocalCSE bug in ignoring traps#8385
Open
kripken wants to merge 2 commits intoWebAssembly:mainfrom
Open
[NFC-for-now] Fix LocalCSE bug in ignoring traps#8385kripken wants to merge 2 commits intoWebAssembly:mainfrom
kripken wants to merge 2 commits intoWebAssembly:mainfrom
Conversation
tlively
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code did "trap = false; scan()", but that is wrong, as it wants to remove the
trap after the scan. Reorder and just use a ShallowEffectAnalyzer.
But this logic bug was not actually allowing different behavior, see the
detailed comment - we have no effects atm that can distinguish the two cases.
If we add new effects, we might, though, so this is worth doing.