Skip to content

[Types] Fix missing inverse check for described field in isValidSupertype #8378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sumleo wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −0
Open

[Types] Fix missing inverse check for described field in isValidSupertype #8378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee0858e
[Types] Fix missing inverse check for described field in isValidSuper…
sumleo Feb 25, 2026
a4720ef
[wasm-shell] Enable all features before parsing quoted text modules
sumleo Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/tools/wasm-shell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ struct Shell {
std::shared_ptr<Module> wasm;
if (auto* quoted = std::get_if<QuotedModule>(&mod.module)) {
wasm = std::make_shared<Module>();
wasm->features = FeatureSet::All;
switch (quoted->type) {
case QuotedModuleType::Text: {
CHECK_ERR(parseModule(*wasm, quoted->module));
Expand Down
6 changes: 6 additions & 0 deletions src/wasm/wasm-type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2419,6 +2419,12 @@ bool isValidSupertype(const HeapTypeInfo& sub, const HeapTypeInfo& super) {
if (!super.described || sub.described->supertype != super.described) {
return false;
}
} else {
// A supertype of a type without a describes clause must also not have a
// describes clause.
if (super.described) {
return false;
}
Copy link
Member

@kripken kripken Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is not correct, but the spec changed and I'm not sure - @tlively ?

Copy link
Member

@tlively tlively Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct! We do not allow this:

(type $foo (descriptor $super) (struct))
(type $super (sub (describes $foo) (struct)))
(type $sub (sub $super) (struct))

}
SubTyper typer;
switch (sub.kind) {
Expand Down
Loading