Skip to content

panel: add config metadata for launchers#442

Merged
trigg merged 1 commit into
masterfrom
metadata-launchers
May 17, 2026
Merged

panel: add config metadata for launchers#442
trigg merged 1 commit into
masterfrom
metadata-launchers

Conversation

@trigg
Copy link
Copy Markdown
Collaborator

@trigg trigg commented May 17, 2026

No description provided.

@trigg trigg merged commit 00d13b4 into master May 17, 2026
4 checks passed
mark-herbert42 added a commit to mark-herbert42/wf-shell-gtk3 that referenced this pull request May 17, 2026
@mark-herbert42
Copy link
Copy Markdown

made the change in xml file but nothing happens on wcm - still no launchers section there. Does it need some more wcm/wf-config patches to work?

@trigg
Copy link
Copy Markdown
Collaborator Author

trigg commented May 17, 2026

I'm uncertain what would need to be done to add launchers to WCM, this was simply enough to stop a very large amount of warning spam on application startup

@mark-herbert42
Copy link
Copy Markdown

I think I got the reason - in the command plugin the list of commands is declared as compound list option within the plugin code, but in the launchers code it is not so the launchers plugin simply reads the file and do some free-code parsing instead of using wf-config. That's probably the reason why you can configure commands in wcm as dynamic list and add/remove/modify the commands while in launchers it does not show as configurable option even after the metadata xml is updated.

@soreau
Copy link
Copy Markdown
Member

soreau commented May 18, 2026

I think I got the reason - in the command plugin the list of commands is declared as compound list option within the plugin code, but in the launchers code it is not so the launchers plugin simply reads the file and do some free-code parsing instead of using wf-config. That's probably the reason why you can configure commands in wcm as dynamic list and add/remove/modify the commands while in launchers it does not show as configurable option even after the metadata xml is updated.

You are mostly correct. The thing is that for autostart and command plugins, wcm has custom code to support each. For wf-panel launchers, it does not have any special code. Ideally, wcm would support dynamic-list option type out-of-the-box, but it doesn't, because each case is slightly different. The good news is that we want to implement this, but we're not there yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants