ci(d4): run the unit suite on Windows#16
Merged
Merged
Conversation
The Windows job was build+vet only. Add a `go test -tags nohtj2k ./...` step so the code is actually exercised on Windows — catching path-separator, temp-dir, and file-system/byte-order issues macOS can't. Scoped deliberately: unit only (no -tags integration → fixture-gated tests skip, since Windows CI pulls no fixtures); no -race (race+cgo on msys2 Go is brittle and race detection is already covered on macOS — the Windows job's value is platform-specific behavior); htj2k stays disabled (OpenJPH unpackaged for msys2). Verified locally: the full unit suite passes under -tags nohtj2k. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…as red) The D4 Windows-CI PR surfaced that the macOS job's tests/integration suite was already failing on main (last 3 commits red) — two tests not updated for behavior changes that landed earlier: - TestConvertTIFF_NovelCodecs/jpegxl: jpegxl-in-TIFF is non-conformant under the Phase 2 conformance gate (writable bytes opentile can't read back) → now needs --allow-nonconformant. Added a per-codec allowNonconformant flag (jpegxl only; avif/webp/htj2k stay conformant in TIFF per containerCapabilities). - TestDownsample_CMU1SmallRegion: downsample now emits an octave pyramid from the reduced L0 (retile engine), so the output level count no longer equals the source's. Replaced the stale "== source level count" assertion with an octave-structure check (each level = ceil(prev/2), the engine's octave math). Both verified locally; full tests/integration suite green (665s). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Windows CI job was build + vet only. This adds a
go test -tags nohtj2k ./...step so the code is actually exercised on Windows.Scope (deliberate)
-tags integration, so fixture-gated tests skip (Windows CI pulls no fixtures).-race— race+cgo on msys2 Go is brittle, and race detection is already covered on macOS. The Windows job's value is platform-specific behavior (path separators, temp dirs, FS + byte-order semantics).-tags nohtj2k, unchanged).Verification
-tags nohtj2k.🤖 Generated with Claude Code