Skip to content

feat(Home Page): News caching#2326

Merged
hirokiterashima merged 25 commits into
developfrom
news-caching
Jul 9, 2026
Merged

feat(Home Page): News caching#2326
hirokiterashima merged 25 commits into
developfrom
news-caching

Conversation

@Aaron-Detre

@Aaron-Detre Aaron-Detre commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Switched to using the new news endpoints for the home page and dedicated news page which means you no longer have to filter or slice on the client side.

Test

@Aaron-Detre Aaron-Detre self-assigned this Jul 7, 2026
@Aaron-Detre Aaron-Detre added the enhancement New feature of any size or improvement (UI, performance, security) label Jul 7, 2026
@qltysh

qltysh Bot commented Jul 7, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (3)

RatingFile% DiffUncovered Line #s
New Coverage rating: A
src/app/services/news.service.ts83.3%19-20
New Coverage rating: A
src/app/home/admin-latest-news/admin-latest-news.component.ts100.0%
New Coverage rating: B
src/app/news/news.component.ts50.0%47-48
Total83.3%
🤖 Increase coverage with AI coding...
In the `news-caching` branch, add test coverage for this new code:

- `src/app/news/news.component.ts` -- Line 47-48
- `src/app/services/news.service.ts` -- Line 19-20

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@Aaron-Detre Aaron-Detre marked this pull request as ready for review July 8, 2026 02:54

@hirokiterashima hirokiterashima left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirokiterashima hirokiterashima merged commit 330c67f into develop Jul 9, 2026
4 checks passed
@hirokiterashima hirokiterashima deleted the news-caching branch July 9, 2026 17:45
@hirokiterashima

Copy link
Copy Markdown
Member

🎉 This PR is included in version 5.235.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Aaron-Detre Aaron-Detre changed the title News caching feat(Home Page): News caching Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants