Update the algorithm for lastPaintedElement#61
Open
jasonwilliams wants to merge 2 commits into
Open
Conversation
|
This looks like an improvement in spec wording to me, however, you might be interested in: w3c/largest-contentful-paint#171 Basically, this splits the "LCP selection" from new LCP emission parts of the LCP spec. You pass a set of new contentful elements (just as paint timing gives) and you get back the single largest one from that set. If you pass an existing LCP candidate to that list, you will only get back a new candidate that is larger than the previous. For container timing, I think you can:
|
|
And you can read how we integrated into soft-navs / icp spec here: https://wicg.github.io/soft-navigations/#report-interaction-contentful-paints-and-soft-navigations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #53
This changs the semantic of
lastPaintedElementto be the largest element of that frame which was painted, rather than an arbirtary last element which isn't deterministic and can be left open to interpretation.Preview | Diff