Set probes port and scheme based on .spec.manageTLS#821
Merged
Conversation
leochr
previously approved these changes
Dec 1, 2025
| appContainer.StartupProbe = patchFileBasedProbe(instance.Spec.Probes.WebSphereLibertyApplicationProbes.GetDefaultStartupProbe(instance), instance.Spec.Probes.Startup, StartupProbeFileBasedScriptName, StartupProbeFileName) | ||
| probes := instance.Spec.Probes.WebSphereLibertyApplicationProbes | ||
| if probes.Startup != nil { | ||
| appContainer.StartupProbe = patchFileBasedProbe(probes.GetDefaultStartupProbe(instance), probes.GetStartupProbe(), StartupProbeFileBasedScriptName, StartupProbeFileName) |
Member
There was a problem hiding this comment.
Minor: FileName is no longer needed I believe and could be removed.
Contributor
Author
There was a problem hiding this comment.
Thanks, removed the parameter.
kabicin
force-pushed
the
cfg-probes
branch
2 times, most recently
from
edf9a86 to
0f7093e
Compare
leochr
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.spec.manageTLSvalue. For example, if manageTLS is true or undefined, scheme will be HTTPS and otherwise, HTTP.