Harden IPv6 direct host checks#16
Draft
Vrepol wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
Summary
Scope notes
This PR keeps the existing temporary server model: user A can host a local MistV server and advertise a reachable
[IPv6]:PORT; users B/C/D/E can connect when that TCP port is allowed by the OS/router firewall. It does not claim MistV can bypass a firewall that blocks inbound TCP.During local exploration, a 3-5 client encrypted direct-JOIN integration harness exposed unstable group-key convergence unrelated to IPv6 socket/binding behavior, so this PR keeps encrypted IPv6 regression coverage at the existing stable two-client level. That should be tracked separately if reproduced during manual multi-user testing.
Validation
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test --all --all-features --lockedNote: full tests were run outside the local filesystem sandbox because IPv6 loopback binding can fail inside the sandbox with
Operation not permitted.