Fix theme selection bugs: properly persist and apply system theme preference#1192
Draft
Fix theme selection bugs: properly persist and apply system theme preference#1192
Conversation
…rence Co-authored-by: ci010 <8425057+ci010@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix various bugs affecting product experience
Fix theme selection bugs: properly persist and apply system theme preference
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes theme selection issues from #2363 (bugs 4-6):
Changes
Theme preference handling (
AppearanceItems.vue,Context.ts):darkModelnow reads/writesSettings.theme('dark'|'light'|'system') instead of booleanisDarkMediaQueryListlistener forprefers-color-schemechangesContext.tsso system theme changes work even when settings panel is closedLocale updates (en, zh-CN, zh-TW, ja-JP, ko):
darkThemeDescriptionto include "follow system" optionOriginal prompt
This section details on the original issue you should resolve
<issue_title>莫名其妙的 bug 过多,急需打磨产品体验</issue_title>
<issue_description>### 是否已经有人报告过这个问题?
启动器版本
0.52.7
操作系统
Mac
架构
x64
当前行为
虽然能用,但是奇怪的 bug 过多。比如
期望行为
No response
复现步骤
No response
其他信息?
No response</issue_description>
Comments on the Issue (you are @copilot in this section)
@BANSAFAn > ### 是否已经有人报告过这个问题? > * [x] 我已经搜索过现有的问题 > > ### 启动器版本 > 0.52.7 > > ### 操作系统 > Mac > > ### 架构 > x64 > > ### 当前行为 > 虽然能用,但是奇怪的 bug 过多。比如 > > 1. app 会创建 ~/Library/Preferences/xmcl.plist 文件作为配置文件,跟官网的说法不符。我说我想从头配置一下,怎么都删不干净配置文件,原来这里还藏了一个。 > 2. 一上来就莫名其妙创建一个 1.21.8 的实例。无可厚非,但是很莫名其妙。 > 3. 第一次打开设置,老是提示这玩意: > >