Sourcery refactored master branch by sourcery-ai[bot] · Pull Request #1 · VolubleRain1/practical-python

sourcery-ai · 2023-09-18T03:32:19Z

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai

Due to GitHub API limits, only the first 60 comments can be shown.

sourcery-ai · 2023-09-18T03:32:21Z

-        principal = principal - extra_payment
+        principal -= extra_payment
        total_paid = total_paid + extra_payment

    print(month, round(total_paid,2), round(principal, 2))
-    
+


Lines 19-23 refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

sourcery-ai · 2023-09-18T03:32:21Z

-else:
-    filename = input('Enter a filename:')
-
+filename = sys.argv[1] if len(sys.argv) == 2 else input('Enter a filename:')


Lines 25-29 refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-09-18T03:32:21Z

-bounce = 1
-while bounce <= 10:
+for bounce in range(1, 11):
    height = height * (3/5)
    print(bounce, round(height, 4))
-    bounce += 1


Lines 4-8 refactored with the following changes:

Replace while with for (while-to-for)

sourcery-ai · 2023-09-18T03:32:21Z

-else:
-    filename = input('Enter a filename:')
-
+filename = sys.argv[1] if len(sys.argv) == 2 else input('Enter a filename:')


Lines 26-30 refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-09-18T03:32:21Z

-                record = dict(zip(headers, row))
-            else:
-                record = tuple(row)
+            record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-09-18T03:32:22Z

 def main(args):
    if len(args) != 3:
-        raise SystemExit('Usage: %s portfile pricefile' % args[0])
+        raise SystemExit(f'Usage: {args[0]} portfile pricefile')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-09-18T03:32:22Z

-                record = dict(zip(headers, row))
-            else:
-                record = tuple(row)
+            record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-09-18T03:32:22Z

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-09-18T03:32:23Z

    '''
    portfolio = report.read_portfolio(filename)
-    return sum([s.cost() for s in portfolio])
+    return sum(s.cost() for s in portfolio)


Function portfolio_cost refactored with the following changes:

Replace unneeded comprehension with generator (comprehension-to-generator)

sourcery-ai · 2023-09-18T03:32:23Z

 def main(args):
    if len(args) != 2:
-        raise SystemExit('Usage: %s portfoliofile' % args[0])
+        raise SystemExit(f'Usage: {args[0]} portfoliofile')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-09-18T03:32:25Z


-    portfolio = [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]
-    return portfolio
+    return [ Stock(d['name'], d['shares'], d['price']) for d in portdicts ]


Function read_portfolio refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2023-09-18T03:32:25Z

-        raise SystemExit('Usage: %s portfile pricefile format' % args[0])
+        raise SystemExit(f'Usage: {args[0]} portfile pricefile format')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-09-18T03:32:25Z

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-09-18T03:32:25Z

    '''
    portfolio = report.read_portfolio(filename)
-    return sum([s.cost() for s in portfolio])
+    return sum(s.cost() for s in portfolio)


Function portfolio_cost refactored with the following changes:

Replace unneeded comprehension with generator (comprehension-to-generator)

sourcery-ai · 2023-09-18T03:32:25Z

 def main(args):
    if len(args) != 2:
-        raise SystemExit('Usage: %s portfoliofile' % args[0])
+        raise SystemExit(f'Usage: {args[0]} portfoliofile')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-09-18T03:32:26Z

    @property
    def total_cost(self):
-        return sum([s.shares * s.price for s in self._holdings])
+        return sum(s.shares * s.price for s in self._holdings)


Function Portfolio.total_cost refactored with the following changes:

Replace unneeded comprehension with generator (comprehension-to-generator)

sourcery-ai · 2023-09-18T03:32:26Z

 def main(args):
    if len(args) != 4:
-        raise SystemExit('Usage: %s portfile pricefile format' % args[0])
+        raise SystemExit(f'Usage: {args[0]} portfile pricefile format')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-09-18T03:32:27Z

 def main(args):
    if len(args) != 4:
-        raise SystemExit('Usage: %s portfoliofile logfile fmt' % args[0])
+        raise SystemExit(f'Usage: {args[0]} portfoliofile logfile fmt')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-09-18T03:32:27Z

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-09-18T03:32:27Z

 def main(args):
    if len(args) != 2:
-        raise SystemExit('Usage: %s portfoliofile' % args[0])
+        raise SystemExit(f'Usage: {args[0]} portfoliofile')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-09-18T03:32:29Z

 def main(args):
    if len(args) != 4:
-        raise SystemExit('Usage: %s portfile pricefile format' % args[0])
+        raise SystemExit(f'Usage: {args[0]} portfile pricefile format')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-09-18T03:32:29Z

 def main(args):
    if len(args) != 4:
-        raise SystemExit('Usage: %s portfoliofile logfile fmt' % args[0])
+        raise SystemExit(f'Usage: {args[0]} portfoliofile logfile fmt')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-09-18T03:32:29Z

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-09-18T03:32:29Z

 def main(args):
    if len(args) != 2:
-        raise SystemExit('Usage: %s portfoliofile' % args[0])
+        raise SystemExit(f'Usage: {args[0]} portfoliofile')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-09-18T03:32:29Z


    def __contains__(self, name):
-        return any([s.name == name for s in self._holdings])
+        return any(s.name == name for s in self._holdings)


Function Portfolio.__contains__ refactored with the following changes:

Replace unneeded comprehension with generator (comprehension-to-generator)

sourcery-ai · 2023-09-18T03:32:30Z

 def main(args):
    if len(args) != 4:
-        raise SystemExit('Usage: %s portfoliofile logfile fmt' % args[0])
+        raise SystemExit(f'Usage: {args[0]} portfoliofile logfile fmt')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-09-18T03:32:31Z


 def typedproperty(name, expected_type):
-    private_name = '_' + name
+    private_name = f'_{name}'


Function typedproperty refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-09-18T03:32:31Z

-            record = dict(zip(headers, row))
-        else:
-            record = tuple(row)
+        record = dict(zip(headers, row)) if headers else tuple(row)


Function parse_csv refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-09-18T03:32:31Z

 def main(args):
    if len(args) != 2:
-        raise SystemExit('Usage: %s portfoliofile' % args[0])
+        raise SystemExit(f'Usage: {args[0]} portfoliofile')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2023-09-18T03:32:31Z

 def main(args):
    if len(args) != 4:
-        raise SystemExit('Usage: %s portfile pricefile format' % args[0])
+        raise SystemExit(f'Usage: {args[0]} portfile pricefile format')


Function main refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

'Refactored by Sourcery'

0bc0f33

sourcery-ai Bot requested a review from VolubleRain1 September 18, 2023 03:32

sourcery-ai Bot commented Sep 18, 2023

View reviewed changes

		raise SystemExit('Usage: %s portfile pricefile format' % args[0])
		raise SystemExit(f'Usage: {args[0]} portfile pricefile format')

Conversation

sourcery-ai Bot commented Sep 18, 2023

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot Sep 18, 2023

Choose a reason for hiding this comment