RB: Force SampleGridoModel.MATCH_EDGES descale and rescale calls#36
Open
LightArrowsEXE wants to merge 1 commit into
Open
RB: Force SampleGridoModel.MATCH_EDGES descale and rescale calls#36LightArrowsEXE wants to merge 1 commit into
LightArrowsEXE wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently with the following code,
sample_grid_modelis effectively applied twice, which introduces additional shifts and other issues:Since the descale/rescale calls in
RescaleBuilderalready obtain these values fromScalingArgs.from_args, we can applyMATCH_EDGESat these steps instead. Ideally we don't want to mutate theKernelobject though, so I simply added a private wrapper to deal with this for the time being. There's probably a better solution out there, which is what I hope to uncover through this PR too. CC: @IchunjoNote: This issue is possibly also a problem in
vsscale's rescaling functions.