fix(vtable): defer pivot chart constructor render retry - #5276
Open
fangsmile wants to merge 9 commits into
Open
Conversation
Allow pivot chart construction to complete when initial embedded chart rendering depends on callbacks that need the assigned table instance. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Let delayed chart constructor retries surface persistent render failures instead of downgrading them to console logs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Only defer the known pending table-instance render error and keep other chart constructor failures synchronous. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Restrict delayed constructor retries to the Aeolus pipeline error that occurs before the external PivotChart instance is assigned. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use an explicit PivotChart construction signal for deferred label dataFilter rendering instead of matching error messages or stacks. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use a render-error predicate so chart constructor retries are limited to confirmed PivotChart construction timing failures instead of every label dataFilter render error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Clean deferred chart render retry timers on release and add a local bugserver reproduction plus production-path regression coverage. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderSync()when the first constructor render fails before the table instance is assigned.Test plan
git diff --checknpm test -- --runInBand __tests__/chart-graphic.test.ts(blocked locally:jestcommand not found)🤖 Generated with Claude Code