set x_launch & acp_launch fee to 0 and make only be_ops_wallet can call#146
Merged
koo-virtuals merged 3 commits intomainfrom Feb 19, 2026
Merged
set x_launch & acp_launch fee to 0 and make only be_ops_wallet can call#146koo-virtuals merged 3 commits intomainfrom
koo-virtuals merged 3 commits intomainfrom
Conversation
twx-virtuals
previously approved these changes
Feb 19, 2026
twx-virtuals
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Introduces new access control gates on
preLaunchfor two launch modes, which can block launches if allowlists are misconfigured. Also changes upgradeable storage layout, so deployments/upgrades must ensure the new mappings are correctly accounted for.Overview
Restricts who can use special launch modes in
BondingV4.preLaunchnow reverts withUnauthorizedLauncherunless the caller is explicitly allowlisted forLAUNCH_MODE_X_LAUNCH(isXLauncher) orLAUNCH_MODE_ACP_SKILL(isAcpSkillLauncher), and adds owner-only setterssetXLauncher/setAcpSkillLauncherto manage these permissions.Tests are updated/expanded to cover allowlist management and unauthorized launch reverts for both modes. OpenZeppelin upgrade artifacts (
.openzeppelin/base*.json) are updated to reflect the newBondingV4storage layout (new mappings).Written by Cursor Bugbot for commit b884f2c. This will update automatically on new commits. Configure here.