fix: add null guards for job.memos and agent.jobs arrays (#59)#179
Open
degenpepe7 wants to merge 1 commit intoVirtual-Protocol:mainfrom
Open
fix: add null guards for job.memos and agent.jobs arrays (#59)#179degenpepe7 wants to merge 1 commit intoVirtual-Protocol:mainfrom
degenpepe7 wants to merge 1 commit intoVirtual-Protocol:mainfrom
Conversation
…tocol#59) The API can return null for job.memos and agent.jobs fields. Calling .map() or .filter() on null throws TypeError, crashing the SDK. Fixes: - job.memos ?? [] in _hydrateJob() (prevents crash on job hydration) - agent.jobs ?? [] in _hydrateAgent() (prevents crash on agent browse) Closes Virtual-Protocol#59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #59
The API can return
nullforjob.memosandagent.jobsfields. When these are null, calling.map()or.filter()throws:This crashes both seller runtimes (when hydrating incoming jobs) and buyer agents (when browsing agents).
Fix
Added nullish coalescing (
?? []) before array operations on:job.memosin_hydrateJob()(line 372)agent.jobsin_hydrateAgent()(line 421)Null/undefined values gracefully fall back to empty arrays.
Note
This supersedes PR #176 which only fixed
job.memos. This PR also coversagent.jobswhich has the same issue.Testing