Skip to content

Option for default horizontal position! #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fuyangli wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Option for default horizontal position! #6

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0110712
Option for default horizontal position!
fuyangli Oct 15, 2015
8ad03bb
Scroll event and page refresh
fuyangli Oct 15, 2015
ba9160d
Bind to On
fuyangli Oct 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions jquery.scrolly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,11 @@
this.velocity = this.$element.attr('data-velocity');
this.bgStart = parseInt(this.$element.attr('data-fit'), 10);

$(document).scroll(function(){
$(document).bind('scroll', function(){
Copy link
Copy Markdown
Owner

@Victa Victa Oct 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think bind is deprecated, no? Maybe I'm wrong, but we should try to use on instead.

Copy link
Copy Markdown
Author

@fuyangli fuyangli Oct 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you're right!
As seen in http://stackoverflow.com/questions/11847021/jquery-bind-vs-on, bind maps to on, but will be deprecated!

self.didScroll = true;
self.scrolly();
});

setInterval(function() {
if (self.didScroll) {
self.didScroll = false;
self.scrolly();
}
}, 10);
self.scrolly();
};

Plugin.prototype.scrolly = function() {
Expand All @@ -70,7 +65,7 @@
if(this.bgStart){ position = position + this.bgStart; }

if(this.options.bgParallax === true) {
this.$element.css({backgroundPosition: '50% '+position+'px'});
this.$element.css({backgroundPosition: (this.options.horizontalPos || '50%') + ' ' + position+'px'});
} else {
this.$element.css({top: position});
}
Expand Down