Pass view-relative teleport flags through in 1.9->1.8 - #719
Open
Term4 wants to merge 1 commit into
Open
Conversation
1.8 handles the rotation-relative position flags (0x08/0x10) natively, and resolving them against the tracked rotation snaps the camera to a stale look on every teleport. Keep the rotation bits and their deltas on the wire and only resolve the position bits. Since the client applies kept deltas to its own live look, its teleport confirm echoes a rotation the tracker cannot predict - match those confirms on position only and adopt the echoed rotation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.8 handles the rotation-relative position flags (0x08/0x10) natively, and resolving them against the tracked rotation snaps the camera to a stale look on every teleport. Keep the rotation bits and their deltas on the wire and only resolve the position bits.
Since the client applies kept deltas to its own live look, its teleport confirm echoes a rotation the tracker cannot predict - match those confirms on position only and adopt the echoed rotation.