fix: conditionally generate platform jobs in flutter_plugin workflow#1643
Closed
unicoderbot[bot] wants to merge 1 commit into
Closed
fix: conditionally generate platform jobs in flutter_plugin workflow#1643unicoderbot[bot] wants to merge 1 commit into
unicoderbot[bot] wants to merge 1 commit into
Conversation
Closes #469 Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes the flutter_plugin template to only generate platform-specific jobs in the main workflow based on the platforms specified during plugin creation.
What Changed
Wrapped all platform job definitions (android, ios, linux, macos, web, windows) with mustache conditionals:
{{#android}}...{{/android}}{{#ios}}...{{/ios}}{{#linux}}...{{/linux}}{{#macos}}...{{/macos}}{{#web}}...{{/web}}{{#windows}}...{{/windows}}This ensures that only the selected platforms will have their corresponding CI/CD jobs generated in the workflow file.
Why
Previously, all platform jobs were always generated regardless of which platforms were specified during plugin creation, leading to unnecessary CI jobs and potential failures for unsupported platforms.
Closes #469