feat: add --get-url flag to git ls-remote for URL config overrides#1642
Open
unicoderbot[bot] wants to merge 2 commits into
Open
feat: add --get-url flag to git ls-remote for URL config overrides#1642unicoderbot[bot] wants to merge 2 commits into
unicoderbot[bot] wants to merge 2 commits into
Conversation
Closes #1097 Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
--get-urlflag to thegit ls-remotecommand in theGit.reachable()method to respect git config URL rewrites (such asurl.<base>.insteadOf).Why
When checking if a git remote is reachable, the CLI was not respecting git config URL overrides like
insteadOf. This caused the reachability check to fail for URLs that had been configured with rewrites, while the actualflutter pub getcommand would succeed because it honors these overrides.By passing
--get-urltogit ls-remote, the check now behaves consistently with how the actual dependency pull resolves remotes.Changes
--get-urlflag togit ls-remotecommand inGit.reachable()Closes #1097