Skip to content

feat: show full menu on lg#5602

Open
cuzz-venus wants to merge 4 commits into
mainfrom
feat/landing-page-menu
Open

feat: show full menu on lg#5602
cuzz-venus wants to merge 4 commits into
mainfrom
feat/landing-page-menu

Conversation

@cuzz-venus
Copy link
Copy Markdown
Contributor

@cuzz-venus cuzz-venus commented May 25, 2026

Jira ticket(s)

VPD-1293

Changes

  • update menu behavior on 1024px

@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dapp-preview Ready Ready Preview May 26, 2026 11:41am
dapp-testnet Ready Ready Preview May 26, 2026 11:41am
venus.io Ready Ready Preview May 26, 2026 11:41am

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 25, 2026

🦋 Changeset detected

Latest commit: d332d47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 25, 2026

Greptile Summary

This PR lowers the responsive breakpoint for the full desktop navbar from xl (1280 px) to lg (1024 px) across all NavBar components, so the expanded menu, settings button, and dropdown behaviour now activate at 1024 px.

  • All xl: breakpoint prefixes in NavBar, MenuItem, SubMenuContent, SettingsButton, GaslessTransactionSetting, and LanguageSetting are replaced with lg:; the beta badge uses hidden max-lg:inline-block xl:inline-block to stay hidden in the compact 1024–1279 px range.
  • Menu items conditionally reduce their horizontal padding at lg when the ClaimRewardsButton is visible, detected via a data-rewards-button attribute and a group-has-[[data-rewards-button]]/navbar CSS selector.
  • The Swap route is moved from a standalone top-level menu entry into the "Others" submenu (between bridge and port), gaining an iconName in the process.

Confidence Score: 5/5

Safe to merge — changes are scoped to CSS breakpoint classes and a menu-item ordering adjustment with no runtime logic or data-flow impact.

Every changed file is a pure UI/layout adjustment: breakpoint prefixes swapped from xl to lg, one item repositioned in a menu array. No business logic, API calls, or state management is touched.

useMenuItems/index.tsx — the newly added swap submenu item is missing a description field that all other Others submenu entries provide.

Important Files Changed

Filename Overview
apps/evm/src/containers/Layout/NavBar/index.tsx Core navbar updated to show desktop menu at lg (1024px) instead of xl (1280px); adds group/navbar context, data-rewards-button attribute for adaptive padding, and updated gap utilities.
apps/evm/src/containers/Layout/NavBar/MenuItem/index.tsx Breakpoints changed from xl to lg throughout; beta badge hidden at lg range (max-lg:inline-block xl:inline-block); adaptive padding via group-has CSS selector when rewards button is present.
apps/evm/src/containers/Layout/NavBar/useMenuItems/index.tsx Swap route moved from a standalone top-level menu item to the Others submenu; new submenu entry includes iconName but no description, unlike the other submenu items.
apps/evm/src/containers/Layout/NavBar/MenuItem/SubMenuContent/index.tsx xl:min-w-137 changed to lg:min-w-137 to match updated breakpoint strategy; no logic changes.
apps/evm/src/containers/Layout/NavBar/SettingsButton/index.tsx xl:hidden changed to lg:hidden on the mobile settings button, matching the new breakpoint threshold.

Reviews (3): Last reviewed commit: "feat: move swap to other menu" | Re-trigger Greptile

@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 81.26% 45585 / 56096
🔵 Statements 81.26% 45585 / 56096
🔵 Functions 62.36% 648 / 1039
🔵 Branches 72.49% 5159 / 7116
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/containers/Layout/NavBar/index.tsx 0% 0% 0% 0% 1-121
apps/evm/src/containers/Layout/NavBar/MenuItem/index.tsx 0% 0% 0% 0% 1-122
apps/evm/src/containers/Layout/NavBar/MenuItem/SubMenuContent/index.tsx 0% 0% 0% 0% 1-26
apps/evm/src/containers/Layout/NavBar/Settings/GaslessTransactionSetting/index.tsx 0% 0% 0% 0% 1-46
apps/evm/src/containers/Layout/NavBar/Settings/LanguageSetting/index.tsx 0% 0% 0% 0% 1-24
apps/evm/src/containers/Layout/NavBar/SettingsButton/index.tsx 0% 0% 0% 0% 1-40
Generated in workflow #13509 for commit 507fb84 by the Vitest Coverage Report Action

@cuzz-venus cuzz-venus marked this pull request as draft May 25, 2026 08:33
@cuzz-venus
Copy link
Copy Markdown
Contributor Author

@greptile review again

@cuzz-venus cuzz-venus marked this pull request as ready for review May 26, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant