Skip to content

👷 Solc version bump #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atarpara merged 3 commits into from
May 13, 2026
+17 −13
Merged

👷 Solc version bump #1524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7473dd2
👷 SOLC version bump
atarpara May 13, 2026
06fec6d
T
atarpara May 13, 2026
0273e5e
T
atarpara May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
steps:
- uses: actions/checkout@v5
- name: Install Foundry Stable
uses: foundry-rs/foundry-toolchain@v1
uses: foundry-rs/foundry-toolchain@v1.8.0
with:
version: stable
- name: Install Dependencies
Expand All @@ -30,12 +30,12 @@ jobs:
- name: Run Tests with ${{ matrix.profile }}
run: >
( [ "${{ matrix.profile }}" = "post-osaka" ] &&
FOUNDRY_PROFILE=post_osaka forge test --use 0.8.33 &&
FOUNDRY_PROFILE=zksync forge test --use 0.8.33
FOUNDRY_PROFILE=post_osaka forge test --use 0.8.35 &&
FOUNDRY_PROFILE=zksync forge test --use 0.8.35
) ||
( [ "${{ matrix.profile }}" = "post-osaka-via-ir" ] &&
FOUNDRY_PROFILE=post_osaka forge test --use 0.8.33 --via-ir &&
FOUNDRY_PROFILE=zksync forge test --use 0.8.33 --via-ir
FOUNDRY_PROFILE=post_osaka forge test --use 0.8.35 --via-ir &&
FOUNDRY_PROFILE=zksync forge test --use 0.8.35 --via-ir
) ||
( [ "${{ matrix.profile }}" = "solc-past-versions-0" ] &&
FOUNDRY_PROFILE=pre_global_structs forge test --use 0.8.5 --fuzz-runs 16 &&
Expand Down Expand Up @@ -66,7 +66,9 @@ jobs:
forge test --use 0.8.28 --fuzz-runs 16 &&
forge test --use 0.8.29 --fuzz-runs 16 &&
forge test --use 0.8.30 --fuzz-runs 16 &&
forge test --use 0.8.31 --fuzz-runs 16
forge test --use 0.8.31 --fuzz-runs 16 &&
forge test --use 0.8.33 --fuzz-runs 16 &&
forge test --use 0.8.34 --fuzz-runs 16
) ||
( [ "${{ matrix.profile }}" = "via-ir" ] &&
forge test --via-ir
Expand All @@ -90,7 +92,7 @@ jobs:
steps:
- uses: actions/checkout@v5
- name: Install Foundry Stable
uses: foundry-rs/foundry-toolchain@v1
uses: foundry-rs/foundry-toolchain@v1.8.0
with:
version: stable
- name: Install Dependencies
Expand Down Expand Up @@ -131,13 +133,15 @@ jobs:
- name: Checkout code
uses: actions/checkout@v5
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
uses: foundry-rs/foundry-toolchain@v1.8.0
with:
version: stable
- name: Install Dependencies
run: forge install
- name: Generate gas diff
uses: atarpara/foundry-snapshot-diff@v0.8
uses: atarpara/foundry-snapshot-diff@v0.9
with:
foundry-profile: "profile.post_osaka"
id: gas_diff
- name: Save gas diff output
if: steps.gas_diff.outputs.markdown
Expand All @@ -163,7 +167,7 @@ jobs:
- name: Checkout code
uses: actions/checkout@v5
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
uses: foundry-rs/foundry-toolchain@v1.8.0
with:
version: stable
- name: Install Dependencies
Expand Down
6 changes: 3 additions & 3 deletions foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@

# The Default Profile
[profile.default]
solc_version = "0.8.33"
solc_version = "0.8.35"
evm_version = "paris" # osaka will be tested in the CI.
auto_detect_solc = false
optimizer = true
optimizer_runs = 1_000
gas_limit = 100_000_000 # ETH is 30M, but we use a higher value.
skip = ["*/*7702*", "*/*BlockHashLib*", "*/*Transient*", "*/ext/ithaca/*", "*/ext/zksync/*"]
gas_limit = 100_000_000 # ETH is 60M, but we use a higher value.
skip = ["*/*7702*", "*/*BlockHashLib*", "*/*Transient*", "*/ext/ithaca/*", "*/clz/*" ,"*/ext/zksync/*"]
fs_permissions = [{ access = "read", path = "./test/data"}]
remappings = [
"forge-std=test/utils/forge-std/"
Expand Down