Implement GetTTDCallsForSymbols for esReven adapter#1007
Open
razaina wants to merge 2 commits intoVector35:devfrom
Open
Implement GetTTDCallsForSymbols for esReven adapter#1007razaina wants to merge 2 commits intoVector35:devfrom
razaina wants to merge 2 commits intoVector35:devfrom
Conversation
Sends rvn:get-calls-by-symbol:<symbol>[:<start_ret>:<end_ret>] packet and parses the JSON response into TTDCallEvent objects, enabling Binary Ninja's TTD Calls widget to query call history from REVEN.
- Fix extractString lambda to handle optional whitespace after the colon in JSON fields (e.g. `"key": "value"` vs `"key":"value"`), fixing the empty Function column in the TTD Calls widget - Add ttd.queryTimeout, ttd.maxCallsQueryResults, ttd.maxSymbolsLimit adapter settings to control query behaviour - Add ttd.maxSymbolsLimit (default 50, 0 = no limit) to control how many symbols are searched in wildcard queries instead of a hardcoded value - Use the configured limit in both packet formats (with and without return address range); setting to 0 omits the :::N suffix so the server searches all matching symbols - Apply client-side result limiting via ttd.maxCallsQueryResults
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sends rvn:get-calls-by-symbol:[:<start_ret>:<end_ret>] packet
and parses the JSON response into TTDCallEvent objects, enabling
Binary Ninja's TTD Calls widget to query call history from REVEN.