feat(web): 7566 default port + "web" install extra/command (api aliases kept) + panel chrome-lane fix#193
Merged
Merged
Conversation
The API server also serves the Knowledge Workbench UI, so `web` reads truer
than `api` for what people install and run. Make `[web]` the canonical extra
and add an `openkb-web` console script; keep `[api]` (as a self-referential
alias) and `openkb-api` working for backwards compatibility. README and the
rest-api example now lead with the `web` names. `python -m openkb.api` (the
module path) is unchanged.
Also move the default API port off the crowded 8000 to 7566 ("KB" = ASCII
75,66) to cut collisions with other local dev servers. Updated: the argparse
default, the default CORS origins, the Vite dev-proxy target, the
connection-dialog placeholder, and the README/examples. A server already
running on 8000 keeps its port; the new default only applies to freshly
started servers.
Claude-Session: https://claude.ai/code/session_01XMxbhmAkxxVV8CFWCZDBaG
…global chrome pills The docked artifact panel's header action buttons (open-in-tab / download / close) sit at the panel's top-right — exactly where App.tsx's global floating chrome cluster (theme + i18n toggles, `absolute right-3 z-40`) renders. The cluster's higher stacking context covered the download and close buttons. Reserve the ~112px chrome lane on the header with `pr-28`, matching the existing convention used by KbList's header row and KbDetail's gear row, so the panel buttons always clear the pills. Claude-Session: https://claude.ai/code/session_01XMxbhmAkxxVV8CFWCZDBaG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small Workbench/API polish changes on top of the merged workbench frontend.
1. Default port 7566 + name the install extra/command "web"
The API server also serves the Knowledge Workbench UI, so
webreads truer thanapifor what people install and run.[web]is now the canonical extra, with anopenkb-webconsole script.[api](self-referential aliasopenkb[web]) andopenkb-apistill work — no breakage for anyone already using them.python -m openkb.api(the module path) is unchanged.8000 → 7566("KB" = ASCII 75,66) to cut collisions with other local dev servers. Updated: the argparse default, the default CORS origins, the Vite dev-proxy target, the connection-dialog placeholder, and the README + rest-api example.2. Fix ArtifactPanel header buttons hidden under the global chrome pills
The docked artifact panel's header action buttons (open-in-tab / download / close) sit at the panel's top-right — exactly where
App.tsx's global floating chrome cluster (theme + i18n toggles,absolute right-3 z-40) renders, whose higher stacking context covered the download/close buttons. Reserve the ~112px chrome lane withpr-28on the header, matching the existing convention used by KbList's header row and KbDetail's gear row.Verification
npm run build(tsc + vite + i18n guard) greenuvre-resolves the new extras cleanly;uv.lockshows only the newwebextra wiring, no dependency version changesuv run pytest→ 1219 passedopenkb-web→ serves on:7566, web UI + real KBs load correctlyhttps://claude.ai/code/session_01XMxbhmAkxxVV8CFWCZDBaG