Draft
Conversation
The 7 URN search tests sent {"urn": ...} in the search payload, but
ScoreSetsSearch has no `urn` field — Pydantic silently dropped it.
Tests passed coincidentally because each created only one score set,
making unfiltered results match the expected count.
Fix by using {"text": ...} (matching actual frontend behavior) and
adding a second decoy score set to each test so the filter is actually
exercised.
The count query in `search_score_sets` was discarding the return value of `build_search_score_sets_query_filter`, so the count would reflect all score sets in the database rather than only those matching the search filters.
Switch one-to-many experiment relationship loading (keyword_objs, doi_identifiers, publication_identifier_associations, raw_read_identifiers) from joinedload to selectinload inside the contains_eager block. This prevents row multiplication from causing the SQL LIMIT to apply to multiplied rows rather than unique score sets, which resulted in search returning fewer results than expected on databases with rich experiment metadata.
…esults-returns-fewer-than-expected-results fix: Search results returns fewer than expected results
Add DB_POOL_SIZE and DB_MAX_OVERFLOW environment variables to control SQLAlchemy connection pool settings per environment. Enable pool_pre_ping to discard stale connections on checkout. Defaults remain at 5/10 for local development.
…-sizes feat: configure database connection pool via environment variables
…ed-search-by-urn-behavior fix: correct false-positive URN search tests
GET request for multiple score sets
Recently published score sets
…e-score-sets-in-get-endpoint fix: duplicate score sets appearing in GET results
…alibration-me-endpoint feat: add endpoint for user created calibrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
Bug Fixes
Maintenance
N/A