Updating to 7.5#13
Merged
Merged
Conversation
Contributor
Author
|
Oh, I updated TinyCommands, too, and I can submit a pull request for that as well if you'd like. Updating it was similarly uneventful. It was nothing as bad as the API version 14 bump. |
Owner
|
Okay the test workflow failure is on me, I screwed up a path while messing around a while back, but the changes look almost certainly very probably likely to be correct! I'll fix the workflow later. Or I'll forget, one of the two. |
Owner
And that'd be great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, long time fan of yours, part time kofi supporter, first time pull requester. It seems like not much changed in 7.5. Dalamud's API got a version bump, of course. In FFXIVClientStructs, a few things relating to FATES got renamed and some things related to Chocobos are marked as deprecated. I'm not sure why the compiler is shouting at me to use
Levels[0]instead ofDefenderLevelnow, but it does. I think that's everything! I don't know. I just followed the compiler errors and changed things until it compiled. Some of the enums could be wrong. I just used what seemed sensible from the options the compiler gave me. I won't pretend to fully understand whatever black magic wuget does, either. C# is not my typical language of choice. Wuget did whatever it does. Outside of some private projects, I haven't done much on GitHub. This may very well combust into flames as soon as you try to merge it.Since you said you were waiting to resub in #12 , I figured I'd at least try to save you some trouble, small that it is. I habitually update plugins I can't live without while waiting for the official release, which is usually fast enough by most everyone's standards but not fast enough for a gal with a copy of Visual Studio. So I am semi-familiar with Dalamud, already. Everything I learned about programming in general, and Dalamud in particular, came from reading open source software projects such as yours.
(So if I did anything wrong, you have only yourself to blame!)
It does compile! I'm running it locally and it seems to work okay. However, it's not like the WoLua scripts I have include a full function test suite. I should make some kind of testing WoLua script, but doing that is beyond the scope of this pull request.
If you want me to fling the compiled .dll somewhere so you can point to it in the interim, let me know.
Writing this and wrangling GitHub into cooperating took more time than the code changes, but maybe that's a good sign. It means there's little for me to mess up! You might have already updated it in the time it took me to type all of this.