[TF2] Fix flame manager lingering when changing class

[zxz41]

Description

There's currently an issue where tf_flame_manager will sit around and take up an edict whenever the player changes class while a flame manager is active.

It would theoretically be possible to crash a server if the edict count is already very low, and since the flame manager will linger around for the duration of a round(?) Any round that takes over ~30 minutes could be crashed by a single person.

The reason why the entity linger around is a bit silly, whenever BaseClass::Update() (AKA CTFPointManager::Update()) gets called every time this entity thinks. There's some server side checks to see if it's time to remove itself.

First the update functions sets bUpdatePoints to true if there are any points in the list.

source-sdk-2013/src/game/shared/tf/tf_point_manager.cpp

Line 244 in 88fa198

bool bUpdatePoints = m_vecPoints.Count() > 0;

There might be some case (unsure) where we created the manager, but no points have been created yet.

The manager then proceeds to go through every point in the list if any to see if it should be removed. Otherwise it updates to update it's size bounds if applicable.

It then checks against the bool to see if there were actually points to update, if all the points are removed, it'll remove itself. Otherwise it applies the size to itself.

source-sdk-2013/src/game/shared/tf/tf_point_manager.cpp

Lines 291 to 304 in 88fa198

	if ( bUpdatePoints )
	{
	if ( m_vecPoints.Count() == 0 )
	{
	UTIL_Remove( this );
	}
	else
	{
	Vector vExtent = 0.5f * ( vHullMax - vHullMin );
	Vector vOrigin = vHullMin + vExtent;
	SetAbsOrigin( vOrigin );
	UTIL_SetSize( this, -vExtent, vExtent );
	}
	}

The issue is that, if it's list gets emptied outside of it's think function, the update function will just assume no points have been created yet.

I might try to do a more proper refactor on some of the point manager stuff, but for now this band aid solution will do rather than having this issue living rent free in the back of my head. It simply just uses UTIL_Remove like most of everything else in the RemoveOwnedProjectiles function. The point manager is already set up to call ClearPoints before being removed.

The only regression caused by this, is that flame particles will be immediately removed, these were only visible client side. As the points for flames would only be removed on the server.