Skip to content

[TF2] Fix players being stuck in teleporter when being revived in MVM#1954

Open
loporlp wants to merge 1 commit into
ValveSoftware:masterfrom
loporlp:master
Open

[TF2] Fix players being stuck in teleporter when being revived in MVM#1954
loporlp wants to merge 1 commit into
ValveSoftware:masterfrom
loporlp:master

Conversation

@loporlp

@loporlp loporlp commented Jun 7, 2026

Copy link
Copy Markdown

If a player's reanimator is dropped inside a friendly teleporter, they will be trapped upon being revived. This occurs because friendly buildings are added to a filter when checking if the respawn location is valid. This PR fixes this by not ignoring friendly buildings when checking respawn location.

Before:

BEFORE_1.mp4

After:

AFTER_3.mp4

@FlaminSarge

FlaminSarge commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This would trigger the fix if a reanimator is inside a sentry or dispenser as well. While that's probably safer in general, any idea if there's a way to make this happen strictly for teleporters? To that end, it looks like CTraceFilterIgnoreTeammatesAndTeamObjects also has some logic around ignoring spies and stuff, so you may have also fixed an issue where a disguised/cloaked Spy standing on a reanimator would still allow the rez to occur in that spot. Would be interested to see if that's the case.

@loporlp

loporlp commented Jun 8, 2026

Copy link
Copy Markdown
Author

I think we could make this teleporter-specific by creating a new trace filter or modifying CTraceFilterIgnoreTeammatesAndTeamObjects to selectively collide with teleporters while still ignoring other friendly buildings.

That said, I’m leaning toward the current approach because revive placement feels safer when we don’t ignore any entities during the collision check. While sentries/dispensers clipping into a reanimator is probably uncommon, this also protects against future cases involving other collidable entities/buildings without needing additional special cases.

As for a disguised/cloaked spy the fix is triggered, so this should resolve any issues with getting stuck in a spy.

Source.SDK.Base.2013.Multiplayer_replay_2026.06.08-16.25.-.Trim_1.mp4

@FlaminSarge

Copy link
Copy Markdown
Contributor

As for a disguised/cloaked spy the fix is triggered, so this should resolve any issues with getting stuck in a spy.

Nice. I'd be interested to see what happens in the Spy case without the fix (if they have some other failsafe in place), if you have that recording on hand.

@JoriKos

JoriKos commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

While sentries/dispensers clipping into a reanimator is probably uncommon

Happens more often than you think, though generally only to Engineers as they get killed by their own Sentry when it's shooting at something behind them or when they get backstabbed by a Spy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants