Skip to content

Fix FPS-dependent movement acceleration caused by ExtraMouseSample() #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjorn-martinsson wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −0
Open

Fix FPS-dependent movement acceleration caused by ExtraMouseSample() #1949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/game/client/in_main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,6 +1008,17 @@ void CInput::ExtraMouseSample( float frametime, bool active )

cmd->Reset();

// Snapshot movement key state to prevent ExtraMouseSample() from
// consuming impulse-down bits that should be processed by CreateMove().
// This fixes FPS-dependent first-tick acceleration behavior.
// Ref: ValveSoftware/Source-1-Games#8045
kbutton_t saved_forward = in_forward;
kbutton_t saved_back = in_back;
kbutton_t saved_moveleft = in_moveleft;
kbutton_t saved_moveright = in_moveright;
kbutton_t saved_up = in_up;
kbutton_t saved_down = in_down;


QAngle viewangles;
engine->GetViewAngles( viewangles );
Expand Down Expand Up @@ -1106,6 +1117,14 @@ void CInput::ExtraMouseSample( float frametime, bool active )
}
}

// Undo side effects on kbutton_t state so that
// CreateMove() receives the correct impulse transitions.
in_forward = saved_forward;
in_back = saved_back;
in_moveleft = saved_moveleft;
in_moveright = saved_moveright;
in_up = saved_up;
in_down = saved_down;
}

void CInput::CreateMove ( int sequence_number, float input_sample_frametime, bool active )
Expand Down