Skip to content

Use match statement in get_error_message #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 1 commit into from
Apr 15, 2026
Merged

Use match statement in get_error_message #2136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions src/vws_cli/_error_handling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,24 +28,6 @@
@beartype
def get_error_message(exc: Exception) -> str:
"""Get an error message from a VWS exception."""
if isinstance(exc, UnknownTargetError):
return f'Error: Target "{exc.target_id}" does not exist.'

if isinstance(exc, TargetNameExistError):
return f'Error: There is already a target named "{exc.target_name}".'

if isinstance(exc, TargetStatusNotSuccessError):
return (
f'Error: The target "{exc.target_id}" cannot be updated as it is '
"in the processing state."
)

if isinstance(exc, TargetStatusProcessingError):
return (
f'Error: The target "{exc.target_id}" cannot be deleted as it is '
"in the processing state."
)

exc_type_to_message: dict[type[Exception], str] = {
AuthenticationFailureError: "The given secret key was incorrect.",
BadImageError: "Error: The given image is corrupted or the format is not supported.",
Expand All @@ -63,4 +45,22 @@ def get_error_message(exc: Exception) -> str:
ProjectHasNoAPIAccessError: "Error: The request could not be completed because this database is not allowed to make API requests.",
}

return exc_type_to_message[type(exc)]
match exc:
case UnknownTargetError():
return f'Error: Target "{exc.target_id}" does not exist.'
case TargetNameExistError():
return (
f'Error: There is already a target named "{exc.target_name}".'
)
case TargetStatusNotSuccessError():
return (
f'Error: The target "{exc.target_id}" cannot be updated as it is '
"in the processing state."
)
case TargetStatusProcessingError():
return (
f'Error: The target "{exc.target_id}" cannot be deleted as it is '
"in the processing state."
)
case _:
return exc_type_to_message[type(exc)]
Loading
Loading