[Fix] small bug fix#582
Merged
VREMSoftwareDevelopment merged 2 commits intoVREMSoftwareDevelopment:mainfrom Jan 1, 2026
Merged
[Fix] small bug fix#582VREMSoftwareDevelopment merged 2 commits intoVREMSoftwareDevelopment:mainfrom
VREMSoftwareDevelopment merged 2 commits intoVREMSoftwareDevelopment:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses minor consistency and code quality improvements in the test suite. The changes standardize test annotations to use JUnit consistently and improve code readability.
Key changes:
- Standardizes test annotation imports to use
org.junit.Testinstead ofkotlin.test.Test - Updates locale display method call to be explicit with
getDisplayCountry(Locale)parameter - Simplifies lambda expression by removing redundant explicit parameter declaration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WiFiChannelsParameterizedTest.kt | Replaces kotlin.test.Test with org.junit.Test to align with JUnit 4 parameterized test framework usage; simplifies lambda by removing redundant it -> syntax |
| WiFiChannelCountryTest.kt | Updates assertion to use explicit getDisplayCountry(expected) call instead of displayCountry property, making the locale parameter explicit and matching the implementation's behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
=========================================
Coverage 97.67% 97.67%
Complexity 975 975
=========================================
Files 121 121
Lines 2579 2579
Branches 211 211
=========================================
Hits 2519 2519
Misses 21 21
Partials 39 39 🚀 New features to boost your workflow:
|
VREMSoftwareDevelopment
approved these changes
Jan 1, 2026
2265662
into
VREMSoftwareDevelopment:main
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this implement/fix?
kotlin.test.Testimport withorg.junit.TestinWiFiChannelsParameterizedTest.ktto ensure consistent usage of JUnit annotations in the test suite.WiFiChannelCountryTest.ktto usegetDisplayCountry(Locale)for more accurate localization, instead of the deprecated or less specificdisplayCountryproperty.Checklist (required before marking ready)
app/src/test/)