Fix navigation drawer highlighting incorrect menu item after language/theme change#580
Merged
VREMSoftwareDevelopment merged 1 commit intoVREMSoftwareDevelopment:mainfrom Dec 31, 2025
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI state management bug where the navigation drawer highlights the wrong menu item after the activity is recreated due to language or theme changes. The fix disables NavigationView's automatic state saving/restoration mechanism, allowing the app's manual state management through SharedPreferences to work correctly.
- Adds
android:saveEnabled="false"to NavigationView to prevent automatic state restoration conflicts - Resolves incorrect menu highlighting after activity recreation from configuration changes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
=========================================
Coverage 97.67% 97.67%
Complexity 975 975
=========================================
Files 121 121
Lines 2579 2579
Branches 211 211
=========================================
Hits 2519 2519
Misses 21 21
Partials 39 39 🚀 New features to boost your workflow:
|
VREMSoftwareDevelopment
approved these changes
Dec 31, 2025
78b6a81
into
VREMSoftwareDevelopment:main
16 checks passed
Owner
|
Thank you for your contribution |
314systems
added a commit
to 314systems/WiFiAnalyzer
that referenced
this pull request
Dec 31, 2025
…areDevelopment#580) Thank you for your contribution
314systems
added a commit
to 314systems/WiFiAnalyzer
that referenced
this pull request
Dec 31, 2025
…areDevelopment#580) Thank you for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this implement/fix?
android:saveEnabled="false"app/src/main/res/layout/main_activity.xmlonRestoreInstanceState, overwriting the correct state set inonCreatefrom SharedPreferencesBefore: Change language in Settings → Activity recreates → Shows AccessPoints screen but drawer highlights Settings
After: Change language in Settings → Activity recreates → Shows AccessPoints screen and drawer correctly highlights AccessPoints
How was this tested?
Checklist (required before marking ready)
app/src/test/)