Skip to content

[k2] increase log buffer size #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astrophysik merged 2 commits into from
Mar 2, 2026
Merged

[k2] increase log buffer size #1537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f57b5ba
increase log buffer size
astrophysik Feb 27, 2026
0d2faa3
increase log buffer size
astrophysik Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runtime-light/stdlib/diagnostics/contextual-logger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class contextual_logger final : vk::not_copyable {
template<typename... Args>
void contextual_logger::log(kphp::log::level level, std::optional<std::span<void* const>> trace, std::format_string<impl::wrapped_arg_t<Args>...> fmt,
Args&&... args) const noexcept {
static constexpr size_t LOG_BUFFER_SIZE = 512UZ;
static constexpr size_t LOG_BUFFER_SIZE = 2048UZ;
std::array<char, LOG_BUFFER_SIZE> log_buffer; // NOLINT
size_t message_size{impl::format_log_message(log_buffer, fmt, std::forward<Args>(args)...)};
auto message{std::string_view{log_buffer.data(), static_cast<std::string_view::size_type>(message_size)}};
Expand Down
2 changes: 1 addition & 1 deletion runtime-light/stdlib/diagnostics/php-assert.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ void php_warning_impl(php_log_level level, char const* message, va_list args) no
return;
}

constexpr size_t LOG_BUFFER_SIZE = 512;
constexpr size_t LOG_BUFFER_SIZE = 2048UZ;
std::array<char, LOG_BUFFER_SIZE> log_buffer; // NOLINT
const auto recorded{std::vsnprintf(log_buffer.data(), log_buffer.size(), message, args)};
if (recorded <= 0) {
Expand Down
2 changes: 1 addition & 1 deletion runtime-light/stdlib/diagnostics/raw-logger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ struct raw_logger final {
template<typename... Args>
static void log(kphp::log::level level, std::optional<std::span<void* const>> trace, std::format_string<impl::wrapped_arg_t<Args>...> fmt,
Args&&... args) noexcept {
static constexpr size_t LOG_BUFFER_SIZE = 512UZ;
static constexpr size_t LOG_BUFFER_SIZE = 2048UZ;
std::array<char, LOG_BUFFER_SIZE> log_buffer; // NOLINT
size_t message_size{impl::format_log_message(log_buffer, fmt, std::forward<Args>(args)...)};
auto message{std::string_view{log_buffer.data(), static_cast<std::string_view::size_type>(message_size)}};
Expand Down
Loading