Update view to account for JBrowse use-cases#5
Open
dmgaldi wants to merge 2 commits into
Open
Conversation
| FROM | ||
| vdi_control_&1..dataset_visibility v, | ||
| vdi_control_&1..dataset d, | ||
| vdi_control_dev_n.dataset_meta m, |
Collaborator
There was a problem hiding this comment.
you need to use the &1.. macro here, like the lines above
steve-fischer-200
requested changes
Jan 18, 2024
Collaborator
steve-fischer-200
left a comment
steve-fischer-200
left a comment
There was a problem hiding this comment.
the presumption here is that if there is no row in dataset_meta then this dataset is not available. i think that is fair.
we had talked about moving this to the VDI_DATASET_* schema... worth discussing as a FUT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add type, name and description to the
dataset_availabilityview.Testing
Ran query and inspected results.