fix error handling in presenter script#40
Open
steve-fischer-200 wants to merge 1 commit intomasterfrom
Open
Conversation
Collaborator
steve-fischer-200
commented
Mar 25, 2026
steve-fischer-200
commented
- fail if no wdk connection after 180 seconds
- fail on non-zero exit from called scripts
mvnural
reviewed
Mar 25, 2026
|
|
||
| # make output dir and run commands to produce output | ||
|
|
||
| mkdir $DESTINATION_DIRECTORY &&\ |
Member
There was a problem hiding this comment.
Not sure about this one. By chaining commands with &&, it ensures that it doesn't run the subsequent command if the previous one fails.
On the other hand, how likely is it for the mkdir or echo to fail? Unless the idea was to skip running ssCreateWdkMetaBatch if ssCreateWdkRecordsBatch fails.
Member
There was a problem hiding this comment.
If that's what we are after, we should consider extending the chain to include call to ssLoadMultipleBatches as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.