Conversation
SHvatov
suggested changes
Oct 28, 2023
| Session session = new Session(dictionary.getWord(), MAX_ATTEMPTS); | ||
|
|
||
| GuessResult lastResult = null; | ||
| while (!(lastResult instanceof GuessResult.Win) && (!(lastResult instanceof GuessResult.Defeat))) { |
There was a problem hiding this comment.
Я бы просто добавил в GuessResult метод isTerminal - делать проверки через instanceof не самое лучшее решение, особенно с точки зрения дальнейшей поддержки. К примеру, мы захотим добавить терминальный статус — досрочное поражение, и главное будет не забыть его добавить в это условие.
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| public sealed interface GuessResult { | ||
| @SuppressWarnings("unused") |
There was a problem hiding this comment.
Если не используется, то можно удалить
| this.guessCount = 0; | ||
| } | ||
|
|
||
| @NotNull GuessResult guess(String guess) { |
| } | ||
|
|
||
| char guessLetter = guess.charAt(0); | ||
|
|
|
|
||
| @NotNull GuessResult guess(String guess) { | ||
| if (guess.length() != 1) { | ||
| return new GuessResult.IncorrectGuess(userAnswer, attempts, maxAttempts); |
There was a problem hiding this comment.
Тут же можно проверить, что guess.charAt(0) от a до z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.