Skip to content

feat(ship-pr): add test evidence gate to Screenshot Check #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thesergsb wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(ship-pr): add test evidence gate to Screenshot Check #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d076398
feat(ship-pr): add test evidence gate to Screenshot Check section
thesergsb Mar 25, 2026
c0145f8
chore: bump to v0.8.1
thesergsb Mar 25, 2026
2196d80
fix(ship-pr): add polyglot test patterns, E2E detection heuristic, an…
thesergsb Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 0.8.1

### Added
- **`/ship-pr` test evidence gate** — Screenshot Check now also gates on new test files (`*.test.*`, `*.spec.*`). The PR body must include verbose test runner output proving the new tests pass. For Playwright/E2E tests, screenshots of tested behavior are also required.

## 0.8.0

### Added
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.8.0
0.8.1
9 changes: 9 additions & 0 deletions skills/ship-pr/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,15 @@ Update VERSION, package.json, or pyproject.toml (whichever exists). Update CHANG
- If the diff includes files in UI/frontend packages AND `evidence/screenshots/`
is empty or missing: STOP and warn the user. Recommend running /validate
or capturing screenshots now.
- If the diff adds new test files (`*.test.*`, `*.spec.*`, `test_*.py`, `*_test.py`,
`*_test.go`, `*_spec.rb`, `test_*.rb`): the PR body MUST include proof that the
new tests pass. At minimum, embed the verbose test runner output.
To detect Playwright/E2E tests: check for `playwright` imports in the test file,
a `playwright.config.*` at the repo root, or test location in an `e2e/` directory.
If E2E tests are detected, also capture and embed screenshots of the tested behavior.
STOP if no evidence exists — run the tests now and capture output.
STOP if the tests fail — do not embed failure output as "evidence." The tests must
be green before the PR can ship. Report the failures and halt.
- If screenshots exist: continue and embed them in the PR body using absolute GitHub blob URLs.
- Organize screenshots by feature or mode (e.g., "Docker mode" vs "Sprites mode").

Expand Down