fix: proxy base url for frontend#4
Closed
dembygenesis wants to merge 3 commits intomainfrom
Closed
Conversation
| targetPort: 80 | ||
| selector: | ||
| run: backend-app | ||
| run: backend-appa |
Contributor
There was a problem hiding this comment.
Typo here. I would also use the conventional app: backend-app selector and change line 14 in deployments.yaml as well to use app instead of run. Same for frontend.
Also, the selectors in deployment.yaml are not needed as they are used to match on which nodes the pods are scheduled to, not relevant for this use case as all nodes are equal. Missed that in the previous review.
Contributor
Author
There was a problem hiding this comment.
I see, should I ignore this ?
Contributor
There was a problem hiding this comment.
The IDE and you are correct, nowadays it should be there. 👍
villevsv-upcloud
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: