fix(filetype): implement fallback encoding detection for file-like objects - #4435
Open
ujjwalredd wants to merge 3 commits into
Open
fix(filetype): implement fallback encoding detection for file-like objects#4435ujjwalredd wants to merge 3 commits into
ujjwalredd wants to merge 3 commits into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Shadow auto-approve: would not auto-approve because issues were found.
Re-trigger cubic
…ient fallback to final decode
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Shadow auto-approve: would not auto-approve because issues were found.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Shadow auto-approve: would auto-approve. Focused bug fix: text_head now falls back to detect_file_encoding when strict decoding of a file-like object fails, eliminating silent data loss; tests assert preserved characters. No rollout or tradeoff changes.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the
TODOinfiletype.py:text_head.Previously, if a document was passed as a stream (e.g.,
BytesIOfrom an S3 bucket or API payload) and wasn't encoded in UTF-8,text_headwould blindly decode it witherrors="ignore". This caused silent data corruption and stripped characters, leading to downstream file classification failures.Changes:
self._file_argstreams.UnicodeDecodeErrorfallback that routes the byte chunk throughdetect_file_encoding(matching the existing behavior for physical file paths).This hardens the ingestion pipeline for production environments where documents are predominantly handled as in-memory streams.