Fix windows compile warnings#451
Merged
urfeex merged 3 commits intoUniversalRobots:masterfrom Mar 18, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #451 +/- ##
==========================================
- Coverage 76.60% 76.44% -0.16%
==========================================
Files 106 106
Lines 5625 5622 -3
Branches 604 604
==========================================
- Hits 4309 4298 -11
- Misses 1011 1019 +8
Partials 305 305
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
urrsk
force-pushed
the
fixwindowswarnings
branch
7 times, most recently
from
86214fb to
f33bed4
Compare
Member
Author
|
bugbot |
urfeex
requested changes
Mar 4, 2026
urrsk
force-pushed
the
fixwindowswarnings
branch
7 times, most recently
from
d042ec3 to
ea2c46c
Compare
From now all warning is treat as errors
urrsk
force-pushed
the
fixwindowswarnings
branch
from
ea2c46c to
cf8c7b7
Compare
urfeex
approved these changes
Mar 17, 2026
Member
urfeex
left a comment
urfeex
left a comment
There was a problem hiding this comment.
The only thing I have left is exposing the flag as a cmake option. Let me know if you want to implement this or not.
urfeex
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix windows compile warnings and from now all warning is treat as errors