Add check to make sure that program name and save path is specified w…#447
Open
URJala wants to merge 1 commit intoUniversalRobots:masterfrom
Open
Add check to make sure that program name and save path is specified w…#447URJala wants to merge 1 commit intoUniversalRobots:masterfrom
URJala wants to merge 1 commit intoUniversalRobots:masterfrom
Conversation
…hen downloading program. Also renamed the input parameter for clarity
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #447 +/- ##
==========================================
- Coverage 76.33% 76.02% -0.31%
==========================================
Files 104 104
Lines 5531 5536 +5
Branches 594 593 -1
==========================================
- Hits 4222 4209 -13
- Misses 1010 1028 +18
Partials 299 299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hen downloading program.
Also renamed the input parameter for clarity
Note
Low Risk
Low risk: adds simple parameter validation and clearer naming in
commandDownloadProgram, with no changes to protocol logic beyond rejecting empty inputs early.Overview
Tightens
DashboardClientImplX::commandDownloadProgramby renaming the first argument for clarity (filename->program_name) and adding an early guard that returns a failedDashboardResponse(and logs) whenprogram_nameorsave_pathis empty.On valid inputs, the download behavior is unchanged aside from using the clarified variable name when constructing the
/programs/v1/<program>GET request.Written by Cursor Bugbot for commit 6fac043. This will update automatically on new commits. Configure here.