Skip to content

Add check to make sure that program name and save path is specified w…#447

Open
URJala wants to merge 1 commit intoUniversalRobots:masterfrom
URJala:dashboard_x_input_validation
Open

Add check to make sure that program name and save path is specified w…#447
URJala wants to merge 1 commit intoUniversalRobots:masterfrom
URJala:dashboard_x_input_validation

Conversation

@URJala
Copy link
Collaborator

@URJala URJala commented Feb 26, 2026

…hen downloading program.

Also renamed the input parameter for clarity


Note

Low Risk
Low risk: adds simple parameter validation and clearer naming in commandDownloadProgram, with no changes to protocol logic beyond rejecting empty inputs early.

Overview
Tightens DashboardClientImplX::commandDownloadProgram by renaming the first argument for clarity (filename -> program_name) and adding an early guard that returns a failed DashboardResponse (and logs) when program_name or save_path is empty.

On valid inputs, the download behavior is unchanged aside from using the clarified variable name when constructing the /programs/v1/<program> GET request.

Written by Cursor Bugbot for commit 6fac043. This will update automatically on new commits. Configure here.

…hen downloading program.

Also renamed the input parameter for clarity
@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.02%. Comparing base (7b57b66) to head (6fac043).

Files with missing lines Patch % Lines
src/ur/dashboard_client_implementation_x.cpp 18.18% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   76.33%   76.02%   -0.31%     
==========================================
  Files         104      104              
  Lines        5531     5536       +5     
  Branches      594      593       -1     
==========================================
- Hits         4222     4209      -13     
- Misses       1010     1028      +18     
  Partials      299      299              
Flag Coverage Δ
start_ursim 83.57% <ø> (+0.96%) ⬆️
ur20-latest 68.58% <0.00%> (-0.13%) ⬇️
ur5-3.14.3 71.60% <0.00%> (-0.21%) ⬇️
ur5e-10.11.0 64.72% <9.09%> (+<0.01%) ⬆️
ur5e-10.12.0 65.69% <18.18%> (-0.50%) ⬇️
ur5e-10.7.0 63.95% <0.00%> (-0.47%) ⬇️
ur5e-5.9.4 72.25% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant