make all probuilder shapes serializable to avoid warning

[varinotmUnity]

DO NOT FORGET TO INCLUDE A CHANGELOG ENTRY

Purpose of this PR

A change to the editor created warning : "The type Unity.ProBuilder UnityEngine.ProBuilder.Shapes.Cube is being serialized by [SerializeReference], but is missing the [Serializable] attribute. To suppress this warning add [Serializable] or use [MakeSerializable].” warning is thrown"

This was fixed by adding serilizable to all the probuilder shape classes.

Links

https://jira.unity3d.com/browse/PBLD-279

Comments to Reviewers

N/A

[u-pr]

PR Reviewer Guide 🔍

(Review updated until commit 416e9ed)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅ PBLD-279 - Fully compliant Compliant requirements: Added [System.Serializable] attribute to all modified shape classes (Arch, Cone, Cube, Cylinder, Door, Pipe, Plane, Prism, Sphere, Sprite, Stairs, Torus), which resolves the warning caused by [SerializeReference].

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪ The PR consists of repetitive, identical changes (adding an attribute) across multiple files and minor formatting cleanups, making it very easy to review.

🏅 Score: 100 The PR correctly addresses the issue by adding the missing attribute to all relevant classes and includes a changelog entry.

🧪 No relevant tests

🔒 No security concerns identified

⚡ No major issues detected

Update review

---

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

[u-pr]

PR Code Suggestions ✨

No code suggestions found for the PR.

[u-pr]

Persistent review updated to latest commit dc6b640

[u-pr]

Persistent review updated to latest commit 416e9ed

[u-pr]

Persistent review updated to latest commit 416e9ed

[codecov-github-com]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##           master     #642   +/-   ##
=======================================
  Coverage   35.57%   35.57%           
=======================================
  Files         277      277           
  Lines       34900    34900           
=======================================
  Hits        12417    12417           
  Misses      22483    22483           

Flag	Coverage Δ
mac_trunk	35.33% <ø> (ø)
win_trunk	35.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
Runtime/Shapes/Arch.cs	62.69% <ø> (ø)
Runtime/Shapes/Cone.cs	66.66% <ø> (ø)
Runtime/Shapes/Cube.cs	77.77% <ø> (ø)
Runtime/Shapes/Cylinder.cs	73.45% <ø> (ø)
Runtime/Shapes/Door.cs	67.70% <ø> (ø)
Runtime/Shapes/Pipe.cs	65.00% <ø> (ø)
Runtime/Shapes/Plane.cs	54.38% <ø> (ø)
Runtime/Shapes/Prism.cs	66.66% <ø> (ø)
Runtime/Shapes/Sphere.cs	76.66% <ø> (ø)
Runtime/Shapes/Sprite.cs	70.96% <ø> (ø)
... and 2 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jmcduff-unity]

Lgtm 👍

[jmcduff-unity]

I'm guessing once a release is decided this line will be updated?

[varinotmUnity]

yeah this is done afterwards, by the person that will upgrade probuilder to the next version

[varinotmUnity]

/review

[varinotmUnity]

/test_plan

[u-pr]

Test Plan

• Test plan approved by PR author
• Test execution in progress
• Test execution complete
• Ready for merge

---

Summary of Changes & Risk Assessment

Summary of Changes

This PR addresses a serialization warning that appears when UnityEngine.ProBuilder.Shapes types are serialized by [SerializeReference] but are missing the [Serializable] attribute. The fix involves adding the [System.Serializable] attribute to all ProBuilder shape classes (Arch, Cone, Cube, Cylinder, Door, Pipe, Plane, Prism, Sphere, Sprite, Stairs, Torus) and includes a CHANGELOG.md entry.

Risk Assessment

• High Risk Areas: None identified
• Medium Risk Areas: None identified
• Low Risk Areas: Potential for unexpected serialization behavior with existing data if the addition of [System.Serializable] interacts poorly with [SerializeReference] or other serialization mechanisms in unforeseen ways. However, this is generally a safe change.

---

Test Scenarios

Functional Testing

• Verify that creating new instances of any ProBuilder shape (e.g., Arch, Cube, Stairs, Sphere) in the Unity Editor no longer produces the [SerializeReference] warning in the console.
• For each modified shape (Arch, Cone, Cube, Cylinder, Door, Pipe, Plane, Prism, Sphere, Sprite, Stairs, Torus), create an instance in a scene and ensure it is properly added to the hierarchy and displays correctly.
• Create a scene containing multiple instances of various ProBuilder shapes. Save the scene, close Unity, reopen Unity, and load the scene to ensure all shapes are loaded correctly and maintain their properties.

Regression Testing

• Open an existing Unity project (with ProBuilder installed) that contains scenes with ProBuilder shapes created before this PR's changes. Load these scenes and verify that existing shapes are displayed and editable as expected.
• After loading an old scene, modify an existing shape, save the scene, and reload to ensure the changes persist and no new issues arise.
• Test that the minor whitespace changes in Cone.cs, Cube.cs, Cylinder.cs, Door.cs, Pipe.cs, Prism.cs, Sphere.cs, Sprite.cs, Stairs.cs have no functional impact on the respective shapes.

Edge Cases

• Create shapes with extreme parameters (e.g., minimum and maximum allowed values for dimensions, subdivisions, etc.) and verify they serialize/deserialize correctly without corruption.

---

_{💡 This test plan updates automatically when /test_plan is run on new commits. If you have any feedback, please reach out in #ai-qa}

---

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

[u-pr]

Persistent review updated to latest commit 416e9ed