Skip to content

Update dependency RecipeEngine.Modules.Wrench to 2.6.1#429

Open
unity-renovate[bot] wants to merge 1 commit intomasterfrom
renovate/recipeengine.modules.wrench-2.x
Open

Update dependency RecipeEngine.Modules.Wrench to 2.6.1#429
unity-renovate[bot] wants to merge 1 commit intomasterfrom
renovate/recipeengine.modules.wrench-2.x

Conversation

@unity-renovate
Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
RecipeEngine.Modules.Wrench nuget patch 2.6.0 -> 2.6.1

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Unity Renovate Bot.

Copy link
Copy Markdown

@u-pr u-pr bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great
The PR updates Yamato configurations for Wrench and Unity version bumps. The review identified a few inconsistencies in how these updates were applied across different job files, specifically regarding platform coverage and consistent variable usage.

🤖 Helpful? 👍/👎

metadata:
Job Maintainers: '#rm-packageworks'
Wrench: 2.6.0.0
Wrench: 2.6.1.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium
It seems that api-validation-jobs.yml only has a single job update for the 2021.3 Windows environment. Given that validation-jobs.yml (starting at line 67) and preview-a-p-v.yml (starting at line 85) include multiple Unity versions (2022.3, 6000.0, 6000.3, etc.) and platforms (MacOS, Ubuntu), have you considered if these other versions and platforms should also be updated in api-validation-jobs.yml?

🤖 Helpful? 👍/👎

metadata:
Job Maintainers: '#rm-packageworks'
Wrench: 2.6.0.0
Wrench: 2.6.1.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low
This aggregate job only has the Wrench metadata updated to 2.6.1.0. For consistency with the individual jobs in this file (e.g., lines 88, 146, 205), should the UPMPVP_CONTEXT_WRENCH variable also be added or updated here if it's required for the aggregate execution?

🤖 Helpful? 👍/👎

@unity-renovate
Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants